Nicholas Jamieson

Results 113 comments of Nicholas Jamieson

Thanks for reading that issue's comments more thoroughly than I did, @Jelmerro. I'll take a look at `ts-api-utils` to see what'll be involved in getting things upgraded.

This is a port of a Wotan rule - the link is in the docs if you want to see if there are any similar issue in its repo. I...

> I'm not using Wotan though, that's why I placed an issue here. Yeah, that's fine. I was just wondering whether there is a fundamental problem with the rule. >...

For the moment, I've removed `no-misused-generic` from the recommended rules. IMO, it ought to be possible to fix this issue and to address Dan's (by adding an option to allow...

See #3841 - adding this signature essentially removes type checking. #3945 was the fix the problems that signature introduced.

IMO, adding an array overload signature would be the preferred solution. It's simple and easy to understand and will effect errors for `undefined` values, etc. And TypeScript 3.0 supports using...

Also, I'm not entirely sure why making them optional should effect such different behaviour. It's interesting, but I'd have some concerns that the behaviour could change. Especially, if the reason...

> I'm not really sure what the plan for rxjs-traits is right now. It was/is an experiment. And, ATM, I don't have the time (or interest) to further it, so...

The problem is that `GlobalEventHandlersEventMap` is declared in TypeScript's `dom` library - see [here](https://github.com/microsoft/TypeScript/blob/9ff24b6fc87dd4a376a434d1019d356dfe743c53/lib/lib.dom.d.ts#L5682) - but `fromEvent` isn't just for DOM events. It works with Node events too - see...