Nicholas Jamieson comments

Results 113 comments of


                                            Nicholas Jamieson

no-commented-out-code misses JSX comments and one line comments in some occasions

> Do you want me to submit a PR for that? Sure. As you've stated, the whole snippet should be deemed commented-out code.

Add "single" as alternative for observables that only emit once or error and then complete

IMO, this is something that ought to be expressible with TypeScript. And my understanding is that there is some interest in this happening. I don't think there is any appetite...

Add "single" as alternative for observables that only emit once or error and then complete

> Is there some documentation ... ? No. It's literally just an idea, ATM.

docs: add a best practices document

> Maybe other core team members have an opinion as well I don't think this could be merged without discussion. I don't agree with everything in this PR and, FWIW,...

feat(groupBy): add seed option to eagerly create groups

I would not be in favour of this, especially as `seed` is `() => ObservableInput`. That doesn't fit with this description of the feature: > opening groups eagerly I'm also...

`debounceTime` emit right away when they reach the end of the observable they are debouncing

IMO, this isn't a bug and is reasonable behaviour. The point of denouncing is to ensure notifications are not emitted too quickly. If the source completes, there will be no...

`debounceTime` emit right away when they reach the end of the observable they are debouncing

Yeah, if it's the expected behaviour, it should be mentioned in the docs. Also, I guess it could be argued that it should be delayed in some circumstances. If the...

`ngOnDestroy` is not implemented raised by prefer-takeuntil rule when ngOnDestroy is in a super class

See [this comment](https://github.com/cartant/rxjs-tslint-rules/issues/113#issuecomment-578473623) on the TSLint rule equivalent: > I imagine this would be possible, but complicated and I can't see myself having the time to do this anytime soon.

`ngOnDestroy` is not implemented raised by prefer-takeuntil rule when ngOnDestroy is in a super class

@Samuel-Beslogic I just don't have the time to mess with these rules and I've not used them myself lately - as I've not used Angular for years. Rather than messing...

Library is broken with Typescript v5.2

I've taken a look at this. Fixing this is not straightforward, as the error is being effected from a dep that's pretty deep down: https://github.com/ajafff/tsutils/pull/156 A lot of these lint...