Benjamin Sanabria Carr
Benjamin Sanabria Carr
@pellared, @dmathieu, I can pick this up since it looks abandoned, but a few questions: 1. is this still needed? 2. Based on what I see in the [changelog](https://github.com/open-telemetry/opentelemetry-specification/blob/bb3d0a0d14f41ccd3f78852316c77705e722edfa/CHANGELOG.md?plain=1#L1126-L1127), and...
> @carrbs do you have a specific need for JSON parsing to be implemented? @codeboten, not at all, I was just looking for low hanging fruit to work on. Closing...
@codeboten , @pellared should I implement this, (and remove the comment about JSON?), since we are likely just implementing for YAML atm? https://github.com/open-telemetry/opentelemetry-go-contrib/blob/96790b3addf68bdceb23a44d8f080085bfb82936/config/config.go#L116-L118
Spent some more time looking into this and I have questions on what the scope of this issue is. I'm new to otel, so hopefully you can give me some...
I have attempted a variety of arguments to `semconvgen` with no success so I likely need a bit more guidance. I tried following the directions here: https://github.com/open-telemetry/opentelemetry-go/blob/main/RELEASING.md and running it...
> I have no idea. Probably you would have to debug it. > > [Here](https://github.com/open-telemetry/opentelemetry-go-build-tools/tree/main/semconvgen) is the source code of semconvgen (written in Go). > [Here](https://github.com/open-telemetry/build-tools/tree/main/semantic-conventions) is the source code...
I added some more `const`s in this last commit. This would allow us to change the [usage](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/google.golang.org/grpc/otelgrpc/config.go#L88C1-L90C1) mentioned in #4528 like this: https://github.com/open-telemetry/opentelemetry-go/blob/bd60b70c32d3af917c624254540b560ca9301116/semconv/v1.24.0/metric.go#L729-L737 from `opentelemetry-go-contrib/blob/main/instrumentation/google.golang.org/grpc/otelgrpc/config.go`: ```go // original c.rpcDuration, err...
Examples of generated code and comments: - defined `stability` and `brief` (notice the `it_reps()` output can be duplicative, adding "It represents..." to all `brief`s: ```go // RPCServerDuration is the metric...
Update: I added some little string replacements to the jinja template for the metrics, but I believe a better approach would be to add `"ASPNETCore"` and `"JVM"` to the `capitalizations`...
I see four options at this point: 1. Leave the PR as-is, limit the formatting logic of metric names to the metrics jinja template: ```jinja {% macro to_go_name(name) -%} {%-...