carolmorneau
carolmorneau
Adding colours is a neat idea. Application logging as a concept is owned by the main application at the [solace-ai-connector level](https://github.com/SolaceLabs/solace-ai-connector/blob/main/src/solace_ai_connector/common/logging_config.py). If we want to support colours, I believe supports...
Thank you @sobychacko for looking into the issue. The issue is not related to Batch Mode, we are processing messages individually. In our use case, the Spring Message may have...
FYI, since this issue was opened, we found two workarounds in order to avoid loosing payload elements: - Configure consumer's `user-native-decoding` and producer's `use-native-encoding` to `true`. However, [this currently only...
The fix on `4.1.2-SNAPSHOT` looks good to me. Thank you @olegz for the fix
You are right, the proposed design removes the need for batch configuration at the producer. With the proposal, binders could provide 2 producer implementations: **IMPL-1**: Producer is an accumulator (existing...
Thank you @olegz A few suggestions: - Would it make sense to define `scst_batchHeaders` within [BinderHeaders](https://github.com/spring-cloud/spring-cloud-stream/blob/main/core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binder/BinderHeaders.java)? - This method `public BatchMessageBuilder addHeader(String key, Object value)` could potentially be renamed to...
@olegz Have you pushed your commit on the `GH-2969` branch? I can't seem to see it https://github.com/spring-cloud/spring-cloud-stream/compare/main...GH-2969
Thank you @olegz, this looks good to us. This will allow us to standardize on `scst_batchedHeaders`. Since this issue is also about getting the proposed design Spring approved, will there...
Sounds good, this is good to merge Thank you @olegz
This is an interesting PR. Is it still being worked on?