Carolina Nymark comments

Results 541 comments of


                                            Carolina Nymark

Fix default unit issue for tag cloud block

Nik was faster :) Thank you for working on this @akasunil. I'm glad the initial calculations were not needed. This works well both when the theme sets spacing units with...

Add support for Duotone filter and shadow in media & text block

Hi @AKSHAT2802 Are you available to continue working on this change? Can you update the PR with the latest changes from trunk? I am not able to build the PR....

Load variation font faces with theme relative urls using backend provided full urls (_links)

I'm sorry I have not found the time to test this. Truthfully I don't understand the code in this PR, so I would not be able to do a code...

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

I started looking at the font face resolver class, but I have not worked with this feature before so I am not sure if I am approaching this the right...

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

@matiasbenedetto Hi, are you able to provide some insight on the question above?

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

I don't understand. How would **combining** the font families from theme.json and styles/style.json prevent fonts from theme.json from loading?

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

It needs to be solved, because first adding all fonts to theme.json and make all those presets available by default is not a good user experience nor a good developer...

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

I am not sure that the expected result would be for the "Abel" font to remain unchanged when I switch typography presets. I tried to test this in Twenty Twenty-Four....

Font faces defined in variations aren't loaded in the browser until the variation switch is saved and the page is refreshed

I agree that it is never ideal when something is loaded/included and not used. But the same thing will happen if the theme author must include all fonts in theme.json...

Document the auto addition of skip links on Block Themes

The accessibility chapter or section in the theme developer handbook still needs a volunteer to write it. Tracked here: https://github.com/WordPress/Documentation-Issue-Tracker/issues/816