Carolina Nymark

Results 541 comments of Carolina Nymark

I have pushed another update, but I really do not like these changes to post-template/edit.js. The test failures are expected at this time.

There are some issues that I will need to leave for another day (likely Monday) - [x] Displaying the "standard" format on the front. - [x] Styling the select control....

> Displaying the "standard" format on the front. I think the limitation is in the blocks.php file, gutenberg_filter_query_loop_block_query_vars_post_format, since if the `standard ` format is passed to it, it of...

I have replaced the SelectControl with the FormTokenField, but I don't think it is the best control for this low number of set items. The small win with using it,...

> How about using `format` and `formats` parameters? > Is there a reason to use format instead of formats when an array for post formats is used for querying a...

Now custom post types with formats are not filtered in the editor, only on the front, and I don't know what changed.

> Now custom post types with formats are not filtered in the editor, only on the front, and I don't know what changed. I suppose I will start by adding...

> > Now custom post types with formats are not filtered in the editor, only on the front, and I don't know what changed. > > Can you provide reproduction...

Testing instructions have been updated.

So, I added an error_log inside `Gutenberg_REST_Posts_Controller_6_7` that outputs `$this->post_type` and even if I select the custom post type in the editor, the log shows 'post'.