Carlos Mocholí
Carlos Mocholí
@dependabot recreate
Looks like the failure here is caused by the update. Moving it off the milestone
@awaelchli I addressed your comments but did not cherry-pick #14822. It would need to be completely re-done for this branch as the original targets the new lite code.
@tshu-w CI is red, have you checked the failing tests?
Since we are swapping meta-package for a copy-on-build, this shouldn't apply anymore. Closing
I still advocate for removal. This will simplify CI a lot. Easier for us to maintain and for contributors who look at their PR's jobs
Fully agree!
I believe we can deprecate it doing this: ```python from pytorch_lightning.utilities.exceptions import MisconfigurationException class ValueError(ValueError, MisconfigurationException): ... error = ValueError("this is a test") print(isinstance(error, __builtins__.ValueError)) # True print(isinstance(error, MisconfigurationException)) #...
Yes, we would need to hack it so that doesn't happen. Or not deprecate it.