pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

[wip] CI: Combine conda and full testing into a single workflow

Open akihironitta opened this issue 3 years ago • 6 comments

What does this PR do?

Addresses #14059. Includes and closes #14565.

TODO after agreement on the matrix:

  • [x] Update docs
  • [x] Update checkgroup

Version matrix

  • before this change
    • 3.7, 1.9 (full)
    • 3.7, 1.12 (full)
    • 3.8, 1.9 (conda (linux-only))
    • 3.8, 1.10 (conda (linux-only))
    • 3.9, 1.11 (conda (linux-only))
    • 3.9, 1.12 (conda (linux-only))
    • 3.10, 1.12 (full)
  • after this change (open for suggestions on the matrix)
    • 3.7, 1.9
    • 3.7, 1.12
    • 3.8, 1.10
    • 3.9, 1.11
    • ~3.10, 1.9~ (crossed because there's no distribution of PyTorch 1.9 with Python 3.10)
    • 3.10, 1.12

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [x] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @borda

akihironitta avatar Aug 25 '22 13:08 akihironitta

Maybe @Borda could take a final look?

awaelchli avatar Sep 08 '22 21:09 awaelchli

so at least keep Conda for push to master...

Thank you for your review! I don't think running the job on push in master only would be an option because it's likely that the job would be ignored forever.


Shall we continue this discussion in #14059 because there's more information about the motivation for this change?

akihironitta avatar Sep 09 '22 00:09 akihironitta

Shall we continue this discussion in #14059 because there's more information about the motivation for this change?

tbh, not sure what to do... :(

Borda avatar Sep 12 '22 17:09 Borda

I still advocate for removal. This will simplify CI a lot. Easier for us to maintain and for contributors who look at their PR's jobs

carmocca avatar Sep 15 '22 00:09 carmocca

Temporarily keeping conda jobs for reference to see if there's any discrepancy between the conda and full workflows https://github.com/Lightning-AI/lightning/discussions/14059#discussioncomment-3649325.

akihironitta avatar Sep 18 '22 05:09 akihironitta

Codecov Report

Merging #14387 (3581c97) into master (e872b27) will increase coverage by 2%. The diff coverage is n/a.

:exclamation: Current head 3581c97 differs from pull request most recent head eb9d490. Consider uploading reports for the commit eb9d490 to get more accurate results

@@            Coverage Diff             @@
##           master   #14387      +/-   ##
==========================================
+ Coverage      84%      85%      +2%     
==========================================
  Files         395      209     -186     
  Lines       28818    18096   -10722     
==========================================
- Hits        24105    15428    -8677     
+ Misses       4713     2668    -2045     

codecov[bot] avatar Sep 18 '22 05:09 codecov[bot]

It is intentional that all Azure configs are deleted?

Will revert the change! (I just didn't want to occupy the resources with the unrelated change in this PR)

akihironitta avatar Sep 29 '22 10:09 akihironitta

As requested in https://github.com/Lightning-AI/lightning/discussions/14059#discussioncomment-3649325, https://github.com/Lightning-AI/lightning/pull/14387/commits/114a4c0d0301cced58d8c23ead4a33d66ec09f5a added Python/PyTorch versions that were used in conda jobs. If there's no issue with all combinations here, this PR is ready.

@carmocca @awaelchli You've already left an approval, but please have another look if necessary.


Conda installation testing will be added via #14374 independently of this PR.

akihironitta avatar Sep 29 '22 12:09 akihironitta