Carlos Mocholí
Carlos Mocholí
This has come up several times already and people are often confused by it (see also https://github.com/Lightning-AI/litgpt/pull/1179#discussion_r1536989995). What if we simply remove this bit @rasbt, @awaelchli? This is also a...
That works but the counterargument is to keep things simple. If we won't have it by default then I wouldn't have it. But if we don't want anybody having to...
These are all good suggestions. The warning is really old and should be updated to describe these limitations. AFAIK the main missing pieces would be to implement https://github.com/Lightning-AI/lightning/issues/17105 and implement...
It should be `--data.val_split_fraction 0.1` Could you open a PR fixing it?
Can we close this? Anything left?
Since this didn't happen before 2.0, closing as we don't want to do this post 2.0
@awaelchli It would be nice to finish it. Since you are familiar with the state key, do you want to take it? Otherwise I will. Not a high priority of...
@lsy643 Thanks for your contribution. This is blocked by other larger pieces of work so we should revisit this after we can do it. Closing for now, let's continue discussing...
Hi @pjspol! What's the latest reproduction snippet for this bug? The link in https://github.com/Lightning-AI/lightning/issues/14457#issuecomment-1236043241 is private now. This issue needs careful narrowing to find the underlying problem. There were several...
We need to decide the resolution to the conversation above