pytorch-lightning icon indicating copy to clipboard operation
pytorch-lightning copied to clipboard

Enable SyncBatchNorm For LightningLite

Open lsy643 opened this issue 3 years ago • 2 comments

What does this PR do?

Fixes https://github.com/Lightning-AI/lightning/issues/13749

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • [ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes? (if necessary)
  • [ ] Did you write any new necessary tests? (not for typos and docs)
  • [ ] Did you verify new and existing tests pass locally with your changes?
  • [ ] Did you list all the breaking changes introduced by this pull request?
  • [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR. Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • [ ] Is this pull request ready for review? (if not, please submit in draft mode)
  • [ ] Check that all items from Before submitting are resolved
  • [ ] Make sure the title is self-explanatory and the description concisely explains the PR
  • [ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

lsy643 avatar Jul 20 '22 03:07 lsy643

Codecov Report

Merging #13748 (0637e36) into master (c67b075) will decrease coverage by 10%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #13748     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         327      327             
  Lines       25432    25432             
=========================================
- Hits        21862    19342   -2520     
- Misses       3570     6090   +2520     

codecov[bot] avatar Jul 20 '22 03:07 codecov[bot]

LGTM ! Mind adding a test ?

Sure. I was stuck by something else in the past weeks, and I will add it soon

lsy643 avatar Aug 31 '22 03:08 lsy643

@awaelchli, mind checking this one? :otter:

Borda avatar Sep 22 '22 10:09 Borda

@Borda I replied already on the linked issue https://github.com/Lightning-AI/lightning/issues/13749#issuecomment-1250146805

awaelchli avatar Sep 22 '22 10:09 awaelchli

@lsy643 Thanks for your contribution. This is blocked by other larger pieces of work so we should revisit this after we can do it. Closing for now, let's continue discussing in the linked issue.

carmocca avatar Nov 08 '22 16:11 carmocca