Christopher Carman

Results 31 comments of Christopher Carman

I've been experiencing this same issue. ```TypeError: Return value of LanguageServer\DefinitionResolver::resolveExpressionNodeToType() must implement interface phpDocumentor\Reflection\Type, null returned in /Users/christopher_carman/.vscode/extensions/felixfbecker.php-intellisense-1.1.3/vendor/felixfbecker/language-server/src/DefinitionResolver.php:445 Stack trace: #0 /Users/christopher_carman/.vscode/extensions/felixfbecker.php-intellisense-1.1.3/vendor/felixfbecker/language-server/src/DefinitionResolver.php(239): LanguageServer\DefinitionResolver->resolveExpressionNodeToType(Object(PhpParser\Node\Expr\FuncCall)) #1 /Users/christopher_carman/.vscode/extensions/felixfbecker.php-intellisense-1.1.3/vendor/felixfbecker/language-server/src/NodeVisitor/ReferencesCollector.php(38): LanguageServer\DefinitionResolver->resolveReferenceNodeToFqn(Object(PhpParser\Node\Expr\MethodCall)) #2 /Users/christopher_carman/.vscode/extensions/felixfbecker.php-intellisense-1.1.3/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php(108): LanguageServer\NodeVisitor\ReferencesCollector->enterNode(Object(PhpParser\Node\Expr\MethodCall))...

There is also no input for initial position unlike `ngDraggable`.

> @narrowizard With `--quiet` warnings aren't reported at all. I think what @sa9sha9 is looking for is way to have `error` level findings cause a fail, while still having a...

Looks like this _may_ be a limitation of Github and they have adding support for it in their backlog: https://github.com/github/feedback/discussions/9875#discussioncomment-2113787

Actually It looks like this is already supported: > The final conclusion of the check. Can be one of action_required, cancelled, failure, neutral, success, skipped, stale, or timed_out > —[source](https://docs.github.com/en/rest/checks/runs#:~:text=be%20one%20of-,action_required%2C%20cancelled%2C%20failure%2C%20neutral%2C%20success%2C%20skipped%2C%20stale,-%2C%20or%20timed_out.%20When)...

Note that the spec now has an expanded grey palette with 13 values: ``` #ffffff #fafafa #f5f5f5 #f0f0f0 #d9d9d9 #bfbfbf #8c8c8c #595959 #434343 #262626 #1f1f1f #141414 #000000 ``` https://ant.design/docs/spec/colors#Neutral-Color-Palette This...

I had the same issue. No errors in any of the output channels. VSCode v1.36.1, Mac OSX v10.14.5. Completely closing VSCode and then relaunching solved the issue for me. 🤷‍♂

Forgot to add this occasionally comes back. Restarting appears to be a temporary fix only.

Seems a common strategy for this is to return a promise if no callback function is supplied. Example (`stream-to-array`): > If callback is not defined, then it returns a promise....

Indeed, a lot of progress has been made with a lot of collaboration from the TSLint creator. `no-floating-promises` now exists as a rule here: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-floating-promises.md Here is a list of...