Carlos Lima
Carlos Lima
Hiya! I've made changes to export metrics through JMX for a project. I'd be happy to work with you on making this a proper patch to contribute to the project,...
I did not write the patch, I'm just creating the PR based on #272
@lfrancke old, indeed :sweat_smile: We opted to go a different route so I have no feedback to offer :-) Please, note that I didn't write this patch. This is all...
I created the PR #282 based on @abh1sh2k's branch mentioned above.
@robertsirc I intended for it to be backwards compatible but some details may have escaped my attention. Can you elaborate on what does it break? The new behavior is behind...
@robertsirc I think you meant that I changed the `NewExec` signature. I have pushed a fix for that. Does it solve the problem you raised? Anything else I can add/change...
> we have a style error if you could fix: Ooops. Whitespace mistake, fixed :-)
@robertsirc Is there anything I can do to help move this forward?
@dwalters I've been waiting on a review for this PR for about a year now. It’s clear this isn’t a top priority :-)
> https://github.com/helm/helm/pull/13154/files#r2147057212 is a bug we need to fix I think > > otherwise, most of my comments are style/refactoring type concerns. logic here I think is the way to...