Carlos Cinelli

Results 17 comments of Carlos Cinelli

Hi, Zach, do you have any updates on this bug?

Hi @adeldaoud we have recent theoretical results that covers sensitivity for the ATE using machine learning models, see here: https://arxiv.org/abs/2112.13398

@rafaelslins let us merge only when all changes and new plots are implemented, and everything has been thoroughly tested. For example, the current version has an error for the error...

@rafaelslins for this bug to not happen again, you can save the bounds of the plot and return invisibly. Then you can write a simple test that checks whether the...

Thanks for the comment, Henry! I will take a look at your example and try to explain it better. But just to give a quick answer, the focus here is...

@rafaelslins I think the changes look good! Some thoughts: - [x] we can set the default `except = NULL` since `select` will be the main argument now. Also, we can...

@rafaelslins some problems in the current implementation - [x] the parameter alpha is not being dispatched to the functions

I'm inclined to think this looks cleaner for the bounds ![image](https://user-images.githubusercontent.com/5638899/63568353-c9b62800-c529-11e9-868e-d4afb4edbf08.png) Versus the current version ![image](https://user-images.githubusercontent.com/5638899/63568422-08e47900-c52a-11e9-9be0-70cb313e5180.png)

For the legend, we could aim for something like this: https://stackoverflow.com/questions/10389967/common-legend-for-multiple-plots-in-r ![](https://i.stack.imgur.com/xTONT.png)

@rafaelslins Rafael, some bugs and other problems were introduced in this PR. I'm going to list some of them. - [ ] The argument multiple = F is not working....