Carlos Hurtado

Results 8 comments of Carlos Hurtado

Hi! If no one else is working on datafusion-functions-nested, I can take that.

@Jefffrey, for `datafusion-functions-nested` it suffices to add `#![deny(clippy::allow_attributes)]` as there is no usage of `#[allow]`. The same applies to `datafusion-functions-table`. If it's ok, I'll create a PR to enforce `clippy::allow_attributes`...

Hi team. If no one else is working on it, I'll take the following crates: + [x] datafusion-physical-expr-adapter + [x] datafusion-physical-expr-common + [x] datafusion-physical-optimizer

Hi all. When trying to use `#[expect]` in https://github.com/apache/datafusion/blob/6746007826ebd3fcb5614bf87183674435bbb134/datafusion/physical-optimizer/src/aggregate_statistics.rs#L43-L98 I get the following error when running `sh ci/scripts/rust_clippy.sh`: ``` error: this lint expectation is unfulfilled --> datafusion/physical-optimizer/src/aggregate_statistics.rs:44:14 | 44 |...

Makes sense. For now, raised PR with local allow. Thanks @Jefffrey! Tried to do iterative approach but it's indeed a bit of complex work.

@kumarUjjawal, let's remember that the purpose of `expect` is to be identical to `allow`, but [will cause a lint to be emitted when the code it decorates does not raise...

Deep dived a little bit and found [*AWS Pi Week 2021: Amazon S3 Strong Consistency | AWS Events*](https://www.youtube.com/watch?v=B0yXz6EeCaA&list=PL2yQDdvlhXf8vAnQB10dCPIeWUKdHUgOP&index=15) video on YouTube which is also part of a [*AWS Pi Week...

For the sake of speed, decided to create #916. Could you please confirm if change is ok?