杨朱 · Kiki
杨朱 · Kiki
/hold cancel
/lgtm /assign @jsafrane
/lgtm /assign @rainbowmango for workflow and approval.
The committers listed above are authorized under a signed CLA.:white_check_mark: login: cupnes / name: Yuma Ohgami (b9f23aebfb8e893a740133b657669ed2daf30cf5)
Hello @salehsedghpour, with #4051 merged, The `at risk` label should be removed.
@neolit123 I can do it 😊
but according to the KEP, some commands still need to be implemented. https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/2504-kubeadm-machine-output#goals
I'm not sure whether it is an expected patch for this issue? i.e. add a new toleration into job like ``` {key=node.kubernetes.io/unschedulable, effect:NoSchedule} ``` FYI: - https://github.com/kubernetes/kubernetes/blob/e59eceec480e1e181e38bc29e2c01652ec3c671c/cmd/kubeadm/app/phases/upgrade/health.go#L126 - https://github.com/kubernetes/kubernetes/blob/e59eceec480e1e181e38bc29e2c01652ec3c671c/pkg/scheduler/framework/plugins/nodeunschedulable/node_unschedulable.go#L32 Or...