enhancements
enhancements copied to clipboard
kubernetes
changes KEP-2644 beta target to 1.30
- One-line PR description: changes KEP-2644 beta target to 1.30
- Issue link: #2644
- Other comments:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: carlory Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@carlory We can't move this to beta yet, we need additional tests to be written for that.
@deepakkinni thanks for your review. https://github.com/kubernetes/kubernetes/pull/123151 will add e2e test.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@carlory Why do you add the "hold" to this PR? Are you waiting for anything else?
This KEP can be merged now since the e2e tests PR has already been merged.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: carlory, deepakkinni, xing-yang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~keps/sig-storage/OWNERS~~ [xing-yang]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@carlory Why do you add the "hold" to this PR? Are you waiting for anything else?
@xing-yang It needs to be rewritten with the latest template.
- [Design Details](#design-details)
- [Test Plan](#test-plan)
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit tests](#unit-tests)
- [Integration tests](#integration-tests)
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
- [Rollout, Upgrade and Rollback Planning](#rollout-upgrade-and-rollback-planning)
- [Dependencies](#dependencies)
- [Troubleshooting](#troubleshooting)
the above chapters do not exist. Do we need to add these to this PR?