Carlo Cabrera
Carlo Cabrera
Needs ```diff diff --git a/Formula/deno.rb b/Formula/deno.rb index 5bc873c7ec6..31f7391bc2f 100644 --- a/Formula/deno.rb +++ b/Formula/deno.rb @@ -1,7 +1,6 @@ class Deno < Formula desc "Secure runtime for JavaScript and TypeScript" homepage "https://deno.land/"...
> I am of the opinion that no PRs should be failing CI before merging, so applying a label instead of merging a failing PR is preferable. Yes, agreed. I...
> Approval is still a requirement for merging, unless you are counting `brew pr-publish`. Has that setting been applied to other `homebrew-cask-*` repos? The "Squash and merge" button is green...
Another thought: maybe it is possible to do some combination of 2 and 4. In particular, we can test whether it is possible to link only with the static libraries...
No problem; thanks for the acknowledgment. You can add an e-mail address if you wish, here's an example of my usual `Co-authored-by:` trailer: https://github.com/Homebrew/homebrew-core/commit/6838f14930f89688890c4f430d849abcbfd61a8e Or you can use [email protected].
Glad this is working! I submitted a patch upstream that might help you significantly simplify things here: https://reviews.llvm.org/D134936
I abandoned my patch, but you shouldn't need it anymore, since I recently fixed Homebrew LLVM to enable linkage with the static libraries to just work. I did this via...
Oh, and thanks again for bearing with the breakage and for your flexibility in dealing with it!
In progress at #315.
Try passing ``` -DCMAKE_PREFIX_PATH="$HOME/homebrew" ``` to `cmake`.