Carl Meyer

Results 478 comments of Carl Meyer

Hi @noragen, did I understand correctly in #157 that it works for you with Python 3.8 but not with 3.7.3 as above?

Hi @noragen -- really not sure. I recommend you see if `CallTracer.__call__` is being called; that's the profiler entry point. If not, then the problem is with installing the profiler....

Yeah, when you run `myscript.py` as a script, its module name is `__main__`; when you run `monkeytype stub myscript`, its module name is `myscript`. It may be possible to hack...

Doc clarification added in de7868af5403f4814bcf1c32f61ae697bb2143f1 Thanks for the report! This was definitely an oversight in the documentation, it wasn't at all clear which code `monkeytype run` was intended to trace.

Seems like this is happening inside `RewriteConfigDict`. Pretty hard to track down without a consistent repro. Not sure what the source of non-determinism would be. Will leave this open in...

Hi, thanks for the report! So the default type rewriter in the default config already includes `RewriteLargeUnion` which is intended to address this problem. However, it defaults to rewriting any...

We actually already have `RewriteConfigDict` rewriter also in the default config, which should do precisely the `Union[Dict[T, X], Dict[T, Y]] -> Dict[T, Union[X, Y]]` transform in your first example. Interesting...

I think forgiving parsing would be a reasonable feature for LibCST. It's a common feature for parsers used in IDE contexts, and Parso supports it, which might make it easier...

We can fix (or at least work around this) for the container-visiting behavior of the base `TypeRewriter` by adding some isinstance guards, but it remains kind of an inherent design...

Hmm, interesting approach in #71. That certainly solves the ambiguity, but at the cost of making it impossible to use the `TypeRewriter` dispatch machinery for any custom type; you'd have...