Carl Meyer

Results 478 comments of Carl Meyer

Though I think if we do #1240 (and make it default) that will reduce the priority on this quite a lot. (We should still do it, of course.)

Thanks for the report, and thanks @MeGaGiGaGon for further minimization! It looks like the use of `Awaitable[R]` as the return type in `log_fn` is key -- if `log_fn` is changed...

One interesting note here: `CoroutineType.__await__` returns `Generator[Any, None, _ReturnT_nd_co]` -- that `None` there seems reasonably likely to be the source of the spurious `None` we see in this bug. The...

The 3.12 vs 3.13 distinction here is probably related to the fact that the `Generator` type in typeshed only uses its `ReturnT_co` typevar on 3.13+. This causes us to wrongly...

I filed https://github.com/astral-sh/ty/issues/2426 to more clearly track the issue with the `Generator` type on Python 3.12, which I'm sure is _related_ to this issue, although there may be more to...

Both pyright and pyrefly support `__builtins__.pyi` in the project root or in an extra-path; I think that's sufficient to establish a convention, and we should just make life easier for...

I also don't think we should implement a config option to specify the path to the `__builtins__.py[i]` file. That just seems like extra complexity in our implementation, and extra cognitive...

So basically I think we should implement the simplest-possible (and easiest to implement!) version of this feature, which matches pyright and pyrefly, and not overthink it :)