Carl Csaposs

Results 9 comments of Carl Csaposs

> This link was for Juju, not Charmhub. Sorry, I don't see why it needed to be fixed? This PR updates the link from Charmhub to Juju

+1, it'd be helpful for us to be able to check if a test was skipped during `pytest_collect_modifyitems` We use `pytest_collect_modifyitems` to determine how many machines to provision for CI,...

~~Ran into the same issue, here's a workaround: https://github.com/canonical/data-platform-workflows/blob/main/.github/workflows/_get_workflow_version.yaml~~ To solve this, we're now using this composite action (that implements @maxbergs's [solution](https://github.com/actions/toolkit/issues/1264#issuecomment-1770928498)) https://github.com/canonical/get-workflow-version-action Example usage: ```yaml # Reusable workflow (e.g....

In case it helps anyone, we created a composite action that implements @maxbergs's [solution](https://github.com/actions/toolkit/issues/1264#issuecomment-1770928498) https://github.com/canonical/get-workflow-version-action Example usage: ```yaml # Reusable workflow (e.g. build_charm.yaml) on: workflow_call: jobs: foo: runs-on: ubuntu-latest steps:...

@ckmoga I don't understand exactly what you're trying to accomplish, but it doesn't sound like you're affected by this issue `GITHUB_REF` (or `${{ github.ref }}`) is available in a reusable...

@ckmoga In that case, I think you're encountering a different issue fwiw, I was able to access GITHUB_REF in a reusable workflow: https://github.com/carlcsaposs-canonical/test-reusable-workflow-githubref/actions/runs/9835427768/job/27149037144 https://github.com/carlcsaposs-canonical/test-reusable-workflow-githubref/tree/main/.github/workflows

> It's not obvious to me what the advantage of this solution is over directly passing the called workflow repo and ref as workflow inputs. Especially since for the action...

+1 Example failure (on GitHub-hosted `ubuntu-latest` runner): https://github.com/canonical/pgbouncer-k8s-operator/actions/runs/9557337019/job/26344437669 Raw logs: [job-logs.txt](https://github.com/user-attachments/files/15900047/job-logs.txt)

Potentially related: https://github.com/actions/upload-artifact/issues/569 https://github.com/actions/download-artifact/issues/338