scenario_runner icon indicating copy to clipboard operation
scenario_runner copied to clipboard

Support py_trees 1.x

Open fabianoboril opened this issue 6 years ago • 5 comments

Currently we support only py_trees 0.8.x. Now there is a new release, 1.x:

https://py-trees.readthedocs.io/en/release-1.0.x/index.html

However, with the latest py_trees release, several namings have changed, for example SUCCESS_ON_ONE became SuccessOnOne. We should update to the latest py_trees release and adapt our namings.

fabianoboril avatar Jan 22 '19 06:01 fabianoboril

The changelog can be found here: https://py-trees.readthedocs.io/en/release-1.0.x/changelog.html#changelog

Changes that are problematic for us: SUCCESS_ON_ONE --> SuccessOnOne() SUCCESS_ON_ALL --> SuccessOnAll() No more Python2 support

fabianoboril avatar Jan 23 '19 10:01 fabianoboril

See also PR #26

fabianoboril avatar Jan 23 '19 10:01 fabianoboril

Is our update intended to benefit from these new features?:

[composites] new parallel policies, SuccessOnAll, SuccessOnSelected [decorators] oneshot policies for activating on completion or successful completion only

What is the good stuff of 1.0 that is making us update?

germanros1987 avatar Jan 25 '19 20:01 germanros1987

The new parallel policies may be useful. At the same time, you could mimic this behavior also with py_trees 0.8.

fabianoboril avatar Jan 25 '19 21:01 fabianoboril

FYI Please find below a poetry configuration that seems to work on ubuntu20.04:

[jlu@linux-gp75]> cat ~/carla-test/pyproject.toml
[tool.poetry]
name = "carla-test"
version = "0.0.1"
description = "test carla"

[tool.poetry.dependencies]
python = ">=3.7,<3.8"
xmlschema = "^1.8.0"
numpy = "^1.21.2"
six = "^1.16.0"
#py-trees = "^2.1.6"
py-trees = "<0.9"
ephem = "^4.1"
networkx = "^2.6.3"
Shapely = "^1.7.1"
tabulate = "^0.8.9"

[tool.poetry.dev-dependencies]

[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

julienlau avatar Oct 08 '21 12:10 julienlau