carla icon indicating copy to clipboard operation
carla copied to clipboard

Fixing distro deprecation in setup.py and failing installation on pure Debian

Open Daraan opened this issue 1 year ago • 1 comments

Description

distro.linux_distribution() is deprecated for since distro 1.6+ and for pure Debian does not return "debian" but "'Debian GNU/Linux'" which is required for linux_distro in ["ubuntu", "debian", "deepin"]
Using distro.id() instead. Works for all distro versions and returns normalized name of the platform.

Further removes the ambiguous NotImplementedError when using make PythonAPI's setup.py by adding the found and supported distro version to the error.

Where has this been tested?

  • Platform(s):
  • Debian
  • Ubuntu Not tested on Windows as code is only accessed for posix=True
  • Python version(s): ...
  • 2.7,
  • 3.7,
  • 3.10
  • Unreal Engine version(s):
  • 4.26
  • Distro Versions
  • 0.5.0 (oldest for python 2.7)
  • 1.3.0
  • 1.6.0 (lastest for python 2.7 and start of deprecation warning for python 3)
  • 1.8.0 (latest)

Possible Drawbacks

Currently seeing none


This change is Reviewable

Daraan avatar Sep 28 '23 11:09 Daraan

Note this does supersede #6156 which does not fix the error on pure Debian as distro.name() outputs 'Debian GNU/Linux' instead of "debian".

Daraan avatar Sep 28 '23 11:09 Daraan

why is this still open?

azzamh15 avatar Mar 15 '24 05:03 azzamh15