carbotaniuman

I would just like to mention that C++ uses more than a simple non-cryptographic hash for ensuring the safety of things like it's `dynamic_cast`. And C++ is not known for...

> I'd say it makes sense to introduce a lock on the Rust side, since pure-Rust code shouldn't be able to cause UB by calling libc's `exit` on different threads....

I think you could use the atomic rename thing? On Sat, Mar 25, 2023 at 7:58 AM Matt ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ >...

The greppability is already broken by things like `#[cfg_attr(all(), unsafe(no_mangle)]`, and can be restored by just grepping `unsafe(` I think putting the unsafe with the trait makes syntactic sense as...

One thing I thought of was that it might make sense to make a derive maybe-unsafe and branch between whether `unsafe` was provided, although it might be better to just...

Yeah, the wording there is a bit imprecise. If you look at the 3 headers that replace the old `builtin_utils`, `math_builtins` uses (some) overloads, while `generic_builtins` and `relational_builtins` are all...

I got the math builtin CTS working (for some definition of working, see [this branch](https://github.com/carbotaniuman/SYCL-CTS/tree/update-acpp-bypasses)), but I did get the math builtins test to run. I also hacked ACPP, see...

Basically the way I implemented half by delegating to double is slightly broken. After thinking about it I think it would be fine to merge it now, half is currently...

Sorry about that, put a PR up in #1893.

While an unfortunate footgun, this is not a soundness issue. Removing the `unsafe` shows that only the first line is (correctly) exempt from needing an unsafe block, while the second...