Jelmer Prins

Results 50 comments of Jelmer Prins

The reason why there isn't one at the moment is that you are working directly in the form. If you make a close button you'll need to write extra js...

I didn't say it shouldn't be there. I didn't add it while making it because there was no time left to implement this properly. Adding a close button that will...

I just added that comment there to prevent somebody just adding a close button without the extra functionality that is needed. Yes, I think it would indeed be more user-friendly...

Not my priority now, currently focused on symfony 6

@daphneslootmans sorry for the delay, I was out for almost the whole month of September because of Covid

symlinks are not an option because that won't work on windows servers

Would love to see that included

I'm not sure, there is some magic happening there

Working branch: 3304-pages-rename-html-to-json

Is not backwards compatible, if somebody updates Fork and they use a theme that doesn't have an icon there it won't work. You could implement it in a BC way...