Safia Abdalla

Results 518 comments of Safia Abdalla

> I'm still thinking about it, but will want to get more opinions too. @captainsafia any thoughts on this one? I'd support throwing a custom exception type for things that...

I'm gonna move this out of 9.0 since I don't think we'll be able to deliver something before 9.0 for this. I think this is a good candidate for post-9.0...

@madskonradsen Thanks for reporting this issue! I resolved the stack trace for this and it looks like the `DisallowNonParsableComplexTypesOnParameters` analyzer is throwing this particular error. ``` at Microsoft.AspNetCore.Analyzers.RouteHandlers.RouteHandlerAnalyzer.g__ResovleParameterTypeSymbol|8_2(IParameterSymbol parameterSymbol) ```...

@madskonradsen Great! You can check out the [build from source document](https://github.com/dotnet/aspnetcore/blob/6276d612af5e0d1f4c8953525da9602545735c97/docs/BuildFromSource.md) for instructions on how to set up the repo for local development. You _might_ run into issues here since...

@madskonradsen Yes, I believe the issue here is the fact that `methodSymbol` actually refers to the lambda expression based as an argument to the `MapPost` call (` (TEndpointInput data) =>...

To close the loop on this, @benhopkinstech recently investigated the root cause for this and contributed a fix that should be released in .NET 10 Preview 3. The PR with...

Now that .NET 10 Preview 3 is out, is anyone able to verify that the issue is resolved for them in that version? That would help us with the back...

This issue is persistent and its hard to track down the exact root cause because various incantations of syntax can trigger it. Conclusion: we'll add a top-level try/catch to the...

> Conclusion: we'll add a top-level try/catch to the analyzer to avoid unhandled exceptions leaking out to the compiler/Visual Studio. I followed up on this. It's not recommended to add...

> I see there are changes in RequestDelegateGenerator.cs in other PR. I don't know yet why this change is needed, but I noticed it was explicitly requested by the maintainer....