Safia Abdalla

Results 518 comments of Safia Abdalla

> @captainsafia do you know if small changes like this need to use the formal API review template? @halter73 can provide the conclusive decision but I believe that adding a...

> A user may ignore all warnings and call AuthorizationResult.Failed(null) resulting in an AuthorizationResult with Failure = null and Succeeded = false, handling this could result in breaking changes Triage:...

> Is this being work on, otherwise I would like to pick it up. No one is working on this. We've applied the `help wanted` label so you're welcome to...

Triage: Sticking this into .NET 8 since there is a PR out. We may want to backport this to .NET 6 and 7 as well.

@Youssef1313 Thanks for looking into this? > Should the repo be renormalized when sent for each OS? @dougbu @wtgodbe Do you know if it is possible to configure git to...

> Introduce an editorconfig for codefix tests that sets end_of_line = lf, then the test infrastructure would replace \r\n with \n from inputs How do you go about configuring the...

It seems like both approaches, when done properly, can be achieved by modifying the base Verifier class. I have a slight preference towards the editorconfig option since it seems clearer...

> Thanks for the clarification! > @captainsafia would you like me to try this? The editorconfig strategy didn't work, but does the `ReplaceLineEndings` one work? I would favor that being...

> > The editorconfig strategy didn't work, but does the `ReplaceLineEndings` one work? I would favor that being done [here](https://github.com/dotnet/aspnetcore/blob/main/src/Framework/AspNetCoreAnalyzers/test/Verifiers/CSharpAnalyzerVerifier.cs#L37). > > I prefer moving this workaround to `CSharpAnalyzerVerifier` only...