Andrew LeFevre

Results 51 comments of Andrew LeFevre

I agree, at the very least the error message should be improved, it is very confusing. I specifically looked to see in the flatbuffer docs if include cycles are allowed...

Ok, that's a good temporary solution. I think for the future though, the scoring algorithm should be modified to take multiple files into account. For instance, instead of it being...

I'm really curious as to why goloader breaks in Go 1.11, as the moduledata struct shouldn't have been modified...

I actually haven't implemented creating tasks from an XML file, that's one of the last things I need to do. Once I implement that I'll let you know.

A simple suggestion would be to cache hashes of names so we don't waste cpu cycles rehashing the same inputs, but that may or may not help. The extra allocs...

I would suggest blake3, as it's much faster than blake2 from what I've seen, but there's not an official/reviewed implementation in Go AFAIK

> We implemented a conservative version of this algorithm for https://github.com/mvdan/unparam, so perhaps we can reuse it. What do you mean by saying the algorithm is conservative? I think that...

I think a global salt would be beneficial for sure if it would let us garble more exported method names, which are pretty common in Go. It may also be...

I believe this behavior is due to this logic which I think is outdated, as garble doesn't support plugins anymore: https://github.com/burrowers/garble/blob/master/main.go#L1354

Fields names are reversed as of https://github.com/burrowers/garble/commit/0150aa8bb0ecc95965540c784aa055d361e4ebc9 right?