sshkit

sshkit copied to clipboard

`test()` in `within(dir)` should run after cd into dir

15

Given a `test()` in a `within()`, ``` within('/home/vagrant/app1/current') do if test '[ -e tmp/pids/server.pid ]' execute :kill, '-INT', 'tmp/pids/server.pid' end end ``` Does it make sense to generate the following...

teohm

On exit<>0 netssh backend deletes all command output

4

_execute() in the netssh backend [assigns '' to stdout and stderr](https://github.com/capistrano/sshkit/blob/master/lib/sshkit/backends/netssh.rb#L135) when a non zero exit code which automatically produces the "command stderr: Nothing written" & "command stdout: Nothing written"...

damphyr

:wait option is broken

3

Using 1.1.0. The `wait: n` option for `in: :sequence/:groups` is being ignored. I lookd over the code and can't see `on`'s options being used anywhere, except for `:in`. I'm happy...

jhollinger

Ran into a weird one today, I had something like: ``` rub SSHKit.config.command_map[:rake] = "/usr/local/rbenv/shims/bundle exec rake" SSHKit.config.command_map[:ruby] = "/usr/local/rbenv/shims/ruby" ``` I had a problem with `Rake x.x.x is already...

leehambley

Support project-local known hosts file.

1

I didn't know (until reading the docs) that SSH supports multiple known hosts files, how cool would it be if we could check in to source control (with all the...

leehambley

Functional tests were disabled in CI in #523 due to GitHub Actions issues. This PR plans to reenable functional tests in CI once those issues are resolved. It also cargo-cults...

mattbrictson

download! method doesn't close file

1

which causes hard-to-debug errors when you download many files in a row and try to read the file contents immediately after downloading. It works most of the time, but at...

roooneey

Wait for all threads to finish on parallel runner

2

If there's an error in one thread, we wait for earlier hosts to complete but not for later ones. Ensure consistent behaviour across all hosts by saving the exception and...

djmb

warning: already initialized constant SSHKit::StandardError

2

it seems there is a constant being initialized twice ``` There was an error while trying to load the gem 'kamal'. Gem Load Error is: /Users/dorianmariefr/.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/sshkit-1.23.0/lib/sshkit.rb:3: warning: already initialized constant...

dorianmariecom

This PR allows you to configure SSHKit in a multithreaded environment per run. Currently, this isn't possible because much of the configuration is set in a global class variable under...

javierav