sshkit

sshkit copied to clipboard

Bug: Background doesn't work as expected, should be deprecated and eventually removed

4

https://github.com/capistrano/sshkit/blob/6c81f53eec86443ea4f03fd87ae3350d4d4051ec/lib/sshkit/backends/abstract.rb#L59 The problem is that background simply `nohup` and backgrounds the process using the shell's job control `&`. More often than not, badly behaved daemons still block. There's many hoops...

leehambley

Improve connection pooling cache key scheme

1

See https://github.com/capistrano/sshkit/pull/289 for context. We merged a bit of a kludge.

leehambley

as user not working????

6

``` #!/usr/bin/env ruby require 'sshkit' require 'sshkit/dsl' include SSHKit::DSL on %w{srv16} do |host| as 'jbrein' do execute 'whoami' end end ``` Triggers: ``` vagrant@srv16 password:: ``` where: ``` #!/usr/bin/env ruby...

juanbrein

Feature request: command map suffix

1

`suffix` addition, similarly to `prefix`, would add flexibility to the commands handled, also in terms of combinations, e.g. along the lines of: ``` ruby SSHKit.config.command_map.prefix[command].push("bash -lc '") SSHKit.config.command_map.suffix[command].push(" && exit...

ain

Bug: within(directory){ execute(string) } should either 'just work' or 'boom'

12

docs aren't good enough to explain the design choice IMHO - just check stackoverflow... one solution is just to fix it - use shellwords to properly escape the command ```...

ahoward

Feature: ability to set custom sudo command

15

sometimes it's more comfortable (because of suduers settings) to use sudo -u user cmd sometimes it's better to have sudo su user -c 'cmd' sudo su - user -c 'cmd'...

filimonov

Nested "on" blocks should raise or warn

4

From https://github.com/capistrano/sshkit/issues/348#issuecomment-220160838 > AFAIK nested on blocks were never considered in the design. The fact that it works at all is really just coincidence, due to how the SSHKit DSL...

kenn

Running SSHKit tests with Rake 11.0 reveals many Ruby warnings

2

Rake 11.0 turns on Ruby warnings by default. With warnings enabled, running SSHKit's test suite results in a flood of messages like this: ``` lib/sshkit/runners/group.rb:15: warning: instance variable @group_size not...

mattbrictson

Issue: Trusted strings, shell escaping and backwards compatibility.

7

@ncreuschling @mattbrictson /cc Continuing from the discussion in #283 I'd like to raise the general issue of shell escaping (`shellwords`) and what we mean/expect about "escaping strings" and so forth,...

leehambley

Feature: reset $HOME by using sudo -H

6

The command for sudo ``` def user(&_block) return yield unless options[:user] "sudo -u #{options[:user]} #{environment_string + " " unless environment_string.empty?}-- sh -c '%s'" % %Q{#{yield}} end ``` is not resetting...

epinault