Carles Capellas

Results 12 comments of Carles Capellas

> For anyone interested, I forked the main project and created the following package which has the fix noted above for Webpack 5, along with up-to-date dependencies. Hopefully this can...

Running fine on Android though. The error is raised in web only

> Run the Application on mobile not desktop web Sure, @Lovej4972! No problem when running on mobile. We'd like to get it working on desktop too though, since many of...

I've created a PR that fixes the issue on browsers: https://github.com/meliorence/react-native-snap-carousel/pull/820. I've never used React propTypes, so I'm not sure what consequences the fix might have. If anyone with experience...

@BlameFelix Give a try at https://github.com/meliorence/react-native-snap-carousel/pull/820. I'm getting the carousel working on Google Chrome. What error do you get?

@BlameFelix I don't understand how `react-native-web` is involved here 🤔 If you check the [package.json](https://github.com/meliorence/react-native-snap-carousel/blob/master/package.json) in this repo, it is not registered as a dependency. Leaving that aside, the solution...

@BlameFelix I've finally understood how `react-native-web` is involved; expo adds it as dependency to our project's `package.json`. So yes, fixing the issue in `react-native-web` would do the trick. I've been...

I've created https://github.com/meliorence/react-native-snap-carousel/pull/836, removing references to `ViewPropTypes` instead of mocking the missing properties. Perhaps maintainers of the repo like this approach better even though is not the ideal fix: migrating...

If somebody is willing to provide a better solution, [flow](https://flow.org/) types should be used instead

> Hello, why not? > > containerStyle: ViewPropTypes ? ViewPropTypes.style : null, React expects propTypes to be functions: ``` index.js:1 Warning: Failed prop type: Carousel: prop type `slideStyle` is invalid;...