Can Vural comments

Results 212 comments of


                                            Can Vural

Larastan does not understand dynamic relation resolvers

Hi, This is not supported right now. So I changed it to a feature request. But it's a really niche thing, so it's a low priority to support this.

Query builder `get` does not allow mixing strings and expressions

Hi, Good point. Can you send a PR that changes [this](https://github.com/larastan/larastan/blob/6431d010dd383a9279eb8874a76ddb571738564a/stubs/common/EloquentBuilder.stub#L262) line and adds the expression class there?

Allow merging different types into base Collection

> PHPDoc changes like this should be implemented in the framework Not true actually. Doing it through Larastan actually benefits more users, since we can apply it to more versions...

feat: add dynamic parameter type extensions

I tested it by porting my previous implementation for Larastan to this one, and looks like it works fine! Will try to implement more use cases and see if I...

feat: add dynamic parameter type extensions

@calebdw @ondrejmirtes Sorry to bother you, but I wanted to ask how we can move this forward? I'm really interested in this feature.

feat: add support for Collection, Builder, and Arr pluck

Thank you. I'll review it in the coming couple days.

Still having problems with Eloquent Scope through attribute

Hi, I cannot reproduce it. What I tried is: ```php class BaseModel extends Model {} class Child extends BaseModel { #[Scope] protected function active(Builder $query): void { $query->where('BlockUsageInd', false); }...

Internal error: Method newEloquentBuilder() was not found in reflection of class

Please give some code examples that would re-create this. I took the code from the issue, but could not reproduce a crash.

Caching int with redis returns both ints and strings

Hi, > will return either an int or a string depending if it has been cached or not yet, if using redis as the cache driver. It would be great...

Caching int with redis returns both ints and strings

But making the return type int|string would still not help. Strict comparison with an union type like that will not produce an error.