Can Vural comments

Results 212 comments of


                                            Can Vural

Prevent error Argument #2 ($array) must be of type array

Hi, Cannot merge this without a test. Please try to add a test case.

Internal error: Call to undefined method PHPStan\Type\ObjectType::getValue() while analysing file

Hi, Yeah, the crash should not happen. That should be fixed. But your return annotation should be like `@return array{ background_position: 'App\FullyQualifedName\ImagePosition' ...`

[3.x] feat: add support for config array shapes

This is implemented under `checkConfigTypes` config parameter.

Column with table prefix in `where()` clause not recognized as attribute in joins

Hi, Cannot reproduce this. We already have [this](https://github.com/larastan/larastan/blob/dea1002ae29e2406e4a178598337322df87851f2/tests/Integration/data/model-property-builder.php#L39) test case, and it correctly find the error. And even more if I add `User::query()->join('roles', 'users.role_id', '=', 'roles.id')->where('users.email', 'admin');` it doesn't complain.

Column with table prefix in `where()` clause not recognized as attribute in joins

Thanks I'll check it 👌

Column with table prefix in `where()` clause not recognized as attribute in joins

I see where the problem is now. When we have `table_name.column` we check the column only in database structure, we do not take the `@property` tags into account.

fix: don't exclude blade files so bladestan will work

There is nothing to explain here 🤔 I'll have time tomorrow to work on Larastan. So probably tomorrow it'll be released 👍

fix: don't exclude blade files so bladestan will work

Hi, I totally agree that it shouldn't be in our config. It should be user's choice. But, on the other hand if we now remove it if users have their...

fix: don't exclude blade files so bladestan will work

People do crazy things 🤷🏽 So gonna close this one but will add it to 3.x. Thank you!

Crash when using interfaces

This doesn't make too much sense to me 🤔 And I'm surprised PHPStan does not throw more errors. Because the generic type for any relation only accepts child classes of...