canvasplay

Results 18 comments of canvasplay

Hi guys! Did you have the time to check this? Can I help somehow? From my side everything is working properly ;)

@moloko, about the unit testing, I'm not a unit testing expert and I don't really know how to fit them in this project... but ok, I accept the challenge :)...

Hey! Happy new year! 😄 I have moved forward with QUnit as unit testing engine. I think it is a better way so we can do crossbrowser testing and there...

Besides the formatting changes, the tests part looks much better now 😄

Hi @moloko! Thanks for the review and the testing! I have added the missing semicolons and fixed all the wired trailing spaces, also changed the default value for `handleSessionTime`, I...

Thanks so much for the review @moloko! @pipwerks, I know you are a busy man, but if you could find some time to review this it would be wonderful 😄

Hey @pipwerks! Nice to know you are there 😄, but... wow! This was totally unexpected... Maybe my contribution is now senseless... I just wanted to contribute to a project that...

Hi! About your concern on understanding my `csToISODuration` method, I've been checking out your method and it looks like a simplified version of mine. In my humble opinion, mine is...

Hello! I'm back :D Conflicts solved! Now what?

Hello, sorry for long time inactive. I fixed the error, now it does not parse unwanted pseudo selectors like `:hover`, `:focus`, etc.. Many thanks to @AeonFr helping with the regex.