Can Guler comments

Repositories
Issues
Comments

Results 2 comments of


                                            Can Guler

server: Stats handler and InTapHandle called during critical read path

Anything below line 385, including stats handler, can easily be moved to another go routine: https://github.com/grpc/grpc-go/blob/master/internal/transport/http2_server.go#L385 Code between lines 358 and 385 does some checks and then saves the created...

server: Stats handler and InTapHandle called during critical read path

I changed my draft code a bit more and ran benchmarks. New implementation (with forking a go routine) had ~5% worse QPS and latency results. Code [here](https://github.com/grpc/grpc-go/compare/master...canguler:handle-stream-fork?expand=1). ### Benchmark results:...