hs.zhang

Results 14 comments of hs.zhang

I think EOF should be replaced by _EOF and delete undef? After all, EOF is defined by the standard library. Although this problem can be avoided to some extent by...

According to the current implementation, tags will be specified in Scan vertex, and only vertexes with these tags will be accessed. If it is traversed according to vertexKey, all points...

> Yes, current implementation will ignore vertex without any tags. So do we have to change it to traverse all the vertices regardless of whether there is a corresponding tag?...

I am not very clear about the purpose of providing antlr files. Is it just for developers to understand ngql syntax or will you use antlr to parse ngql?

This is also a key reason why I don't consider using Antlr

https://github.com/sofastack/sofa-jraft/blob/19ed179e02ee9108adc0bbf66badb47f62c62af8/jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java#L1291 在JRaft的stepdown中有更新updateLastLeaderTimestamp,保证了之后的handleElectionTimeout在尝试选举前检查lastLeaderTimestamp间隔小于选举间隔。 在Braft中起到类似作用的应该是FollowerLease,但是在step_down函数中,并没有调用_follower_lease.renew()。 是有其他机制来避免我上面说的问题吗

> 什么情况下,在 send_empty_entries(hearbeat = false) 返回前,会发起 send_entries? 这一点我还没有理太清楚,braft有保证这一点吗? > 11 是指 log_index 吗?例子中是指的哪儿? 是的,11指的是log_index。就是在(3)那一步通过send_entries发送的数据,也就是_append_entries_in_fly队列中的第二个

我理解在加载完snapshot之后相关资源会被清理掉。那么第二次启动的时候并没有snapshot存在,这个时候怎么处理?