Candace Holman
Candace Holman
An example failure from verify-crd-schema. Is it in development? > error running generator schemacheck on group operator.openshift.io: > could not run schemacheck generator for group/version operator.openshift.io/v1: > error in operator/v1/zz_generated.crd-manifests/0000_50_ingress_00_ingresscontrollers-CustomNoUpgrade.crd.yaml:...
No major concerns on my part, just a few comments/nits. /lgtm
@robscott do you want to include all the version packages on that page? In the template we only include two: https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/api-docs/pkg.tpl#L40-L49
We could revert to https://github.com/kubernetes-sigs/gateway-api/blob/b1f655e6e88690b47447643066c550884e2f81ab/hack/api-docs/pkg.tpl, which iterates over the packages, and that would fix one problem.
In yesterday's meeting we decided to officially drop GEP-1282.
/assign @Miciah /assign
See https://github.com/openshift/origin/pull/26089 /approve /lgtm
This probably requires https://github.com/openshift/cloud-provider-aws/pull/57
/retest-required