Results 267 comments of Alex Rothberg

I think this can be fixed with something like this (adding a `is_popped_out`), since the second half of the function works fine: ```js api.check.is_inside_email = function() { if(api.get.current_page() !== "email"...

>As for the code, couldn't/shouldn't the generic parameter rather be declared on the method instead of the class, since it only applies to that method? It applies to a few...

My point there as on the change of the type of `action`, i.e: ```ts register(action: string, args: string | StringDict): void; ``` to ```ts register(action: T, args: string | StringDict):...

At present this code does not work: ```ts const GmailFactory = require('gmail-js'); const gmail = new GmailFactory.Gmail(jQuery) as Gmail; gmail.observe.register('popout_thread', popoutThreadConfig); // this is an issue as on_dom expects a...

well the idea is to provide a default for T so in 99% of use cases the users can use as is. Only in the case of wanting to register...

I think good for review. Only question is whether it makes sense to tighten the typing on register per my comment: https://github.com/KartikTalwar/gmail.js/pull/700/files#r886143560

This should be ready for review. This PR should have no breaking changes. There is an option to tighten the types on `register` but that would be a breaking change...

This is how I would fix this: https://github.com/KartikTalwar/gmail.js/pull/700

Related to this issue, it looks like gmail on the inbox list is setting the `display` style to `none` for the the button if you select and then unselect a...

What about using something like: https://github.com/dementrock/tensorfuse ?