gmail.js icon indicating copy to clipboard operation
gmail.js copied to clipboard

Typing for GmailBindAction Incorrect if register used

Open cancan101 opened this issue 3 years ago • 1 comments

register allows adding arbitrary DOM listeners which in turn means the strict set of possible actions specified GmailBindAction may not be correct. This means the typing on on_dom, on, etc are overly strict. I don't know a clean way to relax this other than changing the type to string. I suppose as a starting point we could relax the typing on on_dom

cancan101 avatar May 31 '22 21:05 cancan101

This is how I would fix this: https://github.com/KartikTalwar/gmail.js/pull/700

cancan101 avatar May 31 '22 21:05 cancan101