Cameron Steffen

Results 107 comments of Cameron Steffen

CC #6862 / https://youtrack.jetbrains.com/issue/RUST-6862/Detect-rustc-sources-in-toolchain-sysroot

> Okay, let’s do that: Do what? Clippy didn't make a suggestion. The lint docs say: > Comparing trait objects pointers compares an vtable addresses which are not guaranteed to...

Okay, so there are two issues here. Correct me if I'm mistaken in any way since I am not very comfortable with pointers in Rust. 1. The `clippy::vtable_address_comparisons` lint is...

> Right; I’ll open a separate issue for that when it becomes relevant. Great! > we can suggest replacing ref-to-pointer casts with `ptr::eq`, but not fat-pointer-to-thin-pointer casts That should be...

I removed some commits to keep this PR focused on a series of related changes. I also took things a bit further by introducing an arena. I think this ultimately...

This blocks me from doing: 1. Use `moduleResolution: bundler` in main `tsconfig.json` 2. Use `moduleResolution: nodenext` in `tsconfig.test.json` 3. Use `isoluatedModules: true` for ts-jest

Maybe my case is a little bit different. Here is a reproduction script. ```bash rails new dd-int-nil && cd dd-int-nil bundle add sidekiq bundle add ddtrace --require 'ddtrace/auto_instrument' rails generate...

That's true it wouldn't break my code, but the error is an unnecessary distraction.

I agree with @alexcrichton. But I would add that I think an `else` clause by itself is kinda cute.