Cameron Steffen

Minor suggestion. The list of crates in the **`Building`** line should match the order that they are printed in the **`Compiling`** lines. That is, the one that has been running...

@nikomatsakis FWIW I think rustfmt will allow ` else { .. };` on the same line if it fits. This would be consistent with if/else (edit: actually not so when...

Hmm isn't it bad that temporaries are not dropped at the end of the let-else statement? That could be surprising for a temporary `MutexGuard` for example.

> The handling and lifetimes of temporaries should be exactly the same with let and with let else; any understanding or intuitions that people have about let should apply to...

> @camsteffen I think this is what #94012 is about. Not 100% sure your bug is fixed with that PR applied to. I don't think so unfortunately, since the drop...

> IDK, personally, I see the ; to be consistent with traditional let which needs them too. I want to make a small distinction here. In those examples, the brace...

> Consider: > > ```rust > thing.map(|inner| let Some(a) = inner else { something }) > ``` I wouldn't expect that to compile in the same way that you can't...

I opened #98672 for the temporaries issue.

Duplicate of #418

I don't know how it could be that generic. There's always `.filter(move |item| set.insert(item))`.