Cam Saul

Fix nested inline fn expansion

4

Fixes #33 The root cause of the issue was that the last form in expanded inline function calls would be marked with `^::transformed` metadata to prevent infinite expansions in cases...

Wrong expansion of inlined forms inside other inlined forms

1

I ran into this issue: ```clj (riddley.walk/macroexpand-all `(= (count [1 2]) (count [3 4]))) ;; -> (. clojure.lang.Util clojure.core/equiv (. clojure.lang.RT (clojure.core/count [1 2])) (clojure.core/count [3 4])) ``` Note the...

Add note about preferring `(if-not (= ...))` over `(if (not= ...))` and `(when-not (= ...))` over `(when (not= ...))`

8

I was surprised this wasn't already in the style guide. This is a widely-agreed-upon idiom, right? Or am I just imagining things.

Add section about Yoda conditions

2

Consider two ways to check what sort of bird we have on hand: 1. `(= bird-type :toucan)` -- one reads this code as "bird type equals toucan" 2. `(= :toucan...

ChangeLog not up to date

1

I was trying to see what's new in 5.7.1 but it looks like 5.6.3 is the last version mentioned in the [ChangeLog](https://github.com/dakrone/cheshire/blob/master/ChangeLog.md)

Async client opens dozens of threads

4

For the purposes of testing something I've tried to issue 60 simultaneous long-running HTTP requests to our web server using the `async` functionality of this lib. However when issuing 30...

Visual glitches when joining same table and field multiple times

2

I noticed this while working on #15863. @flamber did mention visual glitches but the ones I ran into are different than the ones in his screenshot. This occurs when joining...

Dashboard filters are only commited on enter, not blur

8

If I create a SQL query with two params, enter a value for the first, and hit `Tab` (which takes you to the next box) or click on the next...

Hitting enter doesn't save filter changes

4

So I'm typing a new value for my Query Builder filter in and since my hands are already on the keyboard I hit enter thinking it will apply the values...

Notion design doc: https://www.notion.so/metabase/Enable-actions-on-individual-records-0956ae8664fe4eda8aa38311974fd639 Tech design docs: - https://github.com/metabase/eng-tech-designs/pull/7 - https://github.com/metabase/eng-tech-designs/pull/9 # Week 1-2 ## Backend - [x] #22543 - [x] #22544 - [x] #22546 - [x] #22551 - [x]...