Cam Saul
Cam Saul
What version of the lib are you using? We fixed support for non-`saml` namespaces in 2.1.0, so this wouldn't have worked in prior versions because the namespace above is `samlp`
@dbrrr let me know if you get tests green on this
This is actually an MLv1 filter bug, but the reasoning might be a little counterintuitive. It has to do with MBQL `:between` being inclusive, like SQL `BETWEEN`. generates the following...
Test that I used while working on the writeup above. Note that once MLv2 is in place we will probably want to write a proper end-to-end test that uses MLv2...
This only affects `DATE` columns, see notes here https://metaboat.slack.com/archives/C04DN5VRQM6/p1708029162683819?thread_ts=1707995442.019769&cid=C04DN5VRQM6
After looking at this a bit further I'm 90% sure the wrong filter clause originates from the FE. `RelativeDatePicker` is still using MLv1, but even worse it's actually also manipulating...
Ok so [Alex P says the code in question that is buggy is doing questionable things is here](https://metaboat.slack.com/archives/C04CYTEL9N2/p1715106417000569) https://github.com/metabase/metabase/blob/9887f2222dac336f58ee2ed58ac28516c224e908/frontend/src/metabase-lib/filter.ts#L359-L397 So this either needs to get moved into MLv2, or it's...
@albertoperdomo is reporting this is still not working as expected here https://metaboat.slack.com/archives/C01LQQ2UW03/p1716799511920049?thread_ts=1714409208.479349&cid=C01LQQ2UW03
Downgrading to P3 since this doesn't affect any of our officially supported databases in terms of query correctness (only a potential performance issue), [Cube is not an officially supported database](https://www.metabase.com/data_sources/)...
Works fine for me on Windows 11 with a 4k monitor and [Brave Version 1.65.126 Chromium: 124.0.6367.118 (Official Build) (64-bit)](https://brave.com/latest/). This is on `master` tho