Andrea Maria Piana
Andrea Maria Piana
Ok, I have figured out at least what the topic is: They are the partitioned topic of the push notification server. Those are heavy traffic topics as they are used...
> Use a different scheme for push notification servers Don't fetch data from partitioned topics that are not yours (this is currently a bug). We need to create a topic...
The code was still using bloomfilters, there was yet another place where that was not passed :(
@ibrkhalil linting fails, you can run `make lint` locally to see the errors, any formatting can be fixed by running `make lint-fix`, but it will only address formatting issues
Closing as tracked elsewhere.
We can leave this under a flag if designs are not ready, but in the meantime it's good to test it, @qfrank could you please check `make lint`, I think...
> > Also result looks different when is required or is Purchasable is enabled, Design:  PR:  > > I discussed with Pedro from the design team, and the...
This test should not be flaky anymore. Some of the tests that are still flaky: - PushNotifications tests in messenger. This are valuable imo and should be kept, I will...
Another flaky test I have noticed is: ``` [2020-10-08T13:30:30.125Z] goroutine 25870 [syscall, 29 minutes]: [2020-10-08T13:30:30.125Z] github.com/mutecomm/go-sqlcipher._Cfunc_sqlite3_prepare_v2(0x7f453802cfb8, 0x7f4538003540, 0xc0ffffffff, 0xc000010428, 0xc000010430, 0x0) [2020-10-08T13:30:30.125Z] _cgo_gotypes.go:563 +0x4d [2020-10-08T13:30:30.125Z] github.com/mutecomm/go-sqlcipher.(*SQLiteConn).prepare.func2(0xc0002e35e0, 0x7f4538003540, 0xc000010428, 0xc000010430, 0x466720)...
Another flaky test https://ci.status.im/blue/rest/organizations/jenkins/pipelines/status-go/pipelines/prs/pipelines/tests/branches/PR-2060/runs/2/nodes/73/log/?start=0 ``` --- FAIL: TestERC20Transfers (17.65s) [2020-10-21T07:59:57.674Z] --- PASS: TestERC20Transfers/TestInRange (8.95s) [2020-10-21T07:59:57.674Z] --- PASS: TestERC20Transfers/TestInboundEvent (5.14s) [2020-10-21T07:59:57.674Z] --- FAIL: TestERC20Transfers/TestNoEvents (3.55s) [2020-10-21T07:59:57.674Z] downloader_test.go:204: [2020-10-21T07:59:57.674Z] Error Trace: downloader_test.go:204...