status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Published 20 hours ago • verified publisher icon status-im

Allow dApps to suggest change of RPC (EIP-3085 EIP-3326)

Open qfrank opened this issue 2 years ago • 7 comments

fixes #11856

notes: the modification for UI needs improvements, but this PR won't include the improvements(i've discussed with @cammellos before), because i'm not very familiar with UI implementation.

screenshots: image image

qfrank avatar Jul 24 '22 11:07 qfrank

Jenkins Builds

Click to see older builds (36)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:x: a82bb8c9 #1 2022-07-24 11:24:26 ~9 min android-e2e :page_facing_up:log
:x: a82bb8c9 #1 2022-07-24 11:24:32 ~9 min android :page_facing_up:log
:x: a82bb8c9 #1 2022-07-24 11:26:11 ~10 min ios :page_facing_up:log
:x: f571a567 #2 2022-08-10 15:46:49 ~15 min ios :page_facing_up:log
:x: cab81d57 #3 2022-08-10 16:05:17 ~16 min ios :page_facing_up:log
:x: cab81d57 #3 2022-08-10 16:14:54 ~25 min android-e2e :page_facing_up:log
:x: cab81d57 #3 2022-08-10 16:16:30 ~27 min android :page_facing_up:log
:heavy_check_mark: d4ecbd61 #4 2022-08-11 15:43:41 ~10 min ios :package:ipa :calling:
:heavy_check_mark: d4ecbd61 #4 2022-08-11 15:47:34 ~14 min android :package:apk :calling:
:heavy_check_mark: d4ecbd61 #4 2022-08-11 15:50:37 ~17 min android-e2e :package:apk :calling:
:x: d4ecbd61 #1 2022-09-02 12:19:52 ~29 min android :page_facing_up:log
:heavy_check_mark: 14c73ce7 #2 2022-09-08 10:37:46 ~4 min tests :package:log
:heavy_check_mark: 14c73ce7 #2 2022-09-08 10:43:32 ~9 min android-e2e :package:apk :calling:
:heavy_check_mark: 14c73ce7 #2 2022-09-08 10:46:00 ~12 min android :package:apk :calling:
:heavy_check_mark: 14c73ce7 #2 2022-09-08 11:23:45 ~50 min ios :package:ipa :calling:
:x: 464cf7fe #3 2022-09-09 05:40:27 ~1 min tests :page_facing_up:log
:heavy_check_mark: 464cf7fe #3 2022-09-09 05:45:52 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 464cf7fe #3 2022-09-09 05:46:23 ~7 min android :package:apk :calling:
:heavy_check_mark: 464cf7fe #3 2022-09-09 05:51:43 ~13 min ios :package:ipa :calling:
:x: f86511a3 #4 2022-09-15 12:31:35 ~1 min tests :page_facing_up:log
:heavy_check_mark: f86511a3 #4 2022-09-15 12:38:02 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: f86511a3 #4 2022-09-15 12:38:14 ~8 min android :package:apk :calling:
:heavy_check_mark: f86511a3 #4 2022-09-15 12:47:20 ~17 min ios :package:ipa :calling:
:heavy_check_mark: 679ceabd #5 2022-09-16 01:39:40 ~1 min tests :package:log
:heavy_check_mark: 679ceabd #5 2022-09-16 01:45:05 ~7 min android :package:apk :calling:
:heavy_check_mark: 679ceabd #5 2022-09-16 01:45:23 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 679ceabd #5 2022-09-16 01:50:47 ~13 min ios :package:ipa :calling:
:heavy_check_mark: c6f01444 #6 2022-09-17 02:23:11 ~1 min tests :package:log
:heavy_check_mark: b03c3fc6 #7 2022-09-17 02:26:11 ~2 min tests :package:log
:heavy_check_mark: b03c3fc6 #7 2022-09-17 02:31:36 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: b03c3fc6 #7 2022-09-17 02:32:03 ~7 min android :package:apk :calling:
:heavy_check_mark: b03c3fc6 #7 2022-09-17 02:39:01 ~14 min ios :package:ipa :calling:
:heavy_check_mark: 2b1eee50 #8 2022-09-19 15:29:50 ~1 min tests :package:log
:heavy_check_mark: 2b1eee50 #8 2022-09-19 15:35:27 ~7 min android :package:apk :calling:
:heavy_check_mark: 2b1eee50 #8 2022-09-19 15:37:04 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: 2b1eee50 #8 2022-09-19 15:40:56 ~12 min ios :package:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: c983a89f #9 2022-10-11 12:33:43 ~1 min tests :package:log
:heavy_check_mark: c983a89f #9 2022-10-11 12:40:04 ~8 min android :package:apk :calling:
:heavy_check_mark: c983a89f #9 2022-10-11 12:40:33 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: c983a89f #9 2022-10-11 12:44:05 ~12 min ios :package:ipa :calling:
:heavy_check_mark: bc189d3f #10 2022-10-14 08:34:46 ~1 min tests :package:log
:heavy_check_mark: bc189d3f #10 2022-10-14 08:40:22 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: bc189d3f #10 2022-10-14 08:41:37 ~8 min android :package:apk :calling:
:heavy_check_mark: bc189d3f #10 2022-10-14 08:43:41 ~10 min ios :package:ipa :calling:

status-im-auto avatar Jul 24 '22 11:07 status-im-auto

@John-44 could we add this in new designs ?

flexsurfer avatar Jul 25 '22 06:07 flexsurfer

We can leave this under a flag if designs are not ready, but in the meantime it's good to test it, @qfrank could you please check make lint, I think linting is failing, thanks!

cammellos avatar Aug 10 '22 14:08 cammellos

We can leave this under a flag if designs are not ready, but in the meantime it's good to test it, @qfrank could you please check make lint, I think linting is failing, thanks!

done :)

qfrank avatar Aug 10 '22 15:08 qfrank

implementation little bit confusing, because we intercept request in clojure, and make it as an permission request, and intercept response , probably there is a better way to do it, we should try to find

flexsurfer avatar Sep 01 '22 10:09 flexsurfer

Hi @flexsurfer , ready to review :)

qfrank avatar Sep 15 '22 12:09 qfrank

thank you @qfrank left a few comments

flexsurfer avatar Sep 16 '22 08:09 flexsurfer

95% of end-end tests have passed

Total executed tests: 87
Failed tests: 4
Passed tests: 83

IDs of failed tests: 5756,702076,700732,3997

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_highligted, id: 5756

    Device 1: Double tap on: HomeButton
    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]` 
    critical/chats/test_group_chat.py:162: in test_group_chat_highligted
    [self.homes[i].home_button.double_click() for i in range(3)]
critical/chats/test_group_chat.py:162: in <listcomp>
    [self.homes[i].home_button.double_click() for i in range(3)]
../views/base_element.py:110: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:110: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen



    Device sessions

    2. test_group_chat_add_new_member_activity_centre, id: 700732

    Device 3: Find Button by accessibility id: notifications-unread-badge
    Device 3: Tap on found: Button 
    critical/chats/test_group_chat.py:118: in test_group_chat_add_new_member_activity_centre
    self.homes[2].get_chat(self.chat_name).click()
../views/home_view.py:257: in get_chat
    chat_in_ac.wait_for_element(20)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `3`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'ypwgbpm')]/../..` is not found on the screen after wait_for_element



    Device sessions

    3. test_group_chat_leave_relogin, id: 3997

    Device 1: Double tap on: HomeButton
    Device 1: Find HomeButton by xpath: //*[contains(@content-desc,'tab, 1 out of 5')] 
    critical/chats/test_group_chat.py:178: in test_group_chat_leave_relogin
    [self.homes[i].home_button.double_click() for i in range(2)]
critical/chats/test_group_chat.py:178: in <listcomp>
    [self.homes[i].home_button.double_click() for i in range(2)]
../views/base_element.py:110: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:110: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen



    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_browser_delete_close_tabs, id: 702076

    Device 1: Find Button by xpath: //*[contains(@text, 'bbc.com')]/../../../../*[@content-desc='empty-tab']
    Device 1: Tap on found: Button 
    critical/test_public_chat_browsing.py:423: in test_browser_delete_close_tabs
    web_page.element_by_text_part(urls['bbc.com']).wait_for_invisibility_of_element()
../views/base_element.py:144: in wait_for_invisibility_of_element
    raise TimeoutException("Device %s: %s by %s: `%s`  is still visible on the screen after %s seconds after wait_for_invisibility_of_element" % (
 Device 1: Button by xpath: `//*[contains(@text, "bbc.com")]`  is still visible on the screen after 10 seconds after wait_for_invisibility_of_element



    Device sessions

    Passed tests (83)

    Click to expand

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    2. test_browser_bookmarks_create_edit_remove, id: 702077
    Device sessions

    3. test_browser_blocked_url, id: 702072
    Device sessions

    4. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Device sessions

    5. test_browser_web3_permissions_testdapp, id: 702078
    Device sessions

    6. test_public_chat_tag_message, id: 700738
    Device sessions

    7. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    8. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Device sessions

    9. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    10. test_browser_offline, id: 702075
    Device sessions

    11. test_browser_invalid_url, id: 702074
    Device sessions

    Class TestPublicChatMultipleDeviceMerged:

    1. test_public_chat_message_edit, id: 700734
    Device sessions

    2. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    3. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    5. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    6. test_public_chat_link_send_open, id: 700736
    Device sessions

    7. test_public_chat_mark_all_messages_as_read, id: 6270
    Device sessions

    8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    10. test_public_chat_message_delete, id: 700735
    Device sessions

    Class TestPairingSyncMultipleDevicesMerged:

    1. test_pairing_sync_clear_history, id: 702394
    Device sessions

    2. test_pairing_sync_contacts_block_unblock, id: 702196
    Device sessions

    3. test_pairing_sync_initial_profile_picture, id: 702392
    Device sessions

    4. test_pairing_sync_initial_bookmarks, id: 702393
    Device sessions

    5. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Device sessions

    6. test_pairing_sync_1_1_chat_message, id: 702198
    Device sessions

    7. test_pairing_sync_public_chat_add_remove, id: 702199
    Device sessions

    8. test_pairing_sync_initial_public_chats, id: 702195
    Device sessions

    9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
    Device sessions

    Class TestOnboardingOneDeviceMerged:

    1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    2. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    3. test_onboarding_share_contact_address, id: 700743
    Device sessions

    4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    6. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    Class TestWalletManagementDeviceMerged:

    1. test_wallet_manage_assets, id: 700758
    Device sessions

    2. test_wallet_add_account_seed_phrase_validation, id: 700762
    Device sessions

    3. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    4. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    6. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
    Device sessions

    Class TestSendTxDeviceMerged:

    1. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    3. test_send_tx_token_8_decimals, id: 700764
    Device sessions

    4. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_sticker_1_1_public_chat_mainnet, id: 702157
    Device sessions

    2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
    Device sessions

    3. test_ens_mention_push_highlighted_public_chat, id: 702156
    Device sessions

    4. test_ens_mention_nickname_1_1_chat, id: 702155
    Device sessions

    5. test_ens_purchased_in_profile, id: 702152
    Device sessions

    6. test_start_new_chat_public_key_validation, id: 702158
    Device sessions

    Class TestRestoreOneDeviceMerged:

    1. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
    Device sessions

    3. test_restore_seed_phrase_field_validation, id: 700750
    Device sessions

    4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
    Device sessions

    2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    3. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_contact_block_unblock_public_chat_offline, id: 702176
    Device sessions

    2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
    Device sessions

    3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
    Device sessions

    4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
    Device sessions

    5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
    Device sessions

    Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    3. test_group_chat_offline_pn, id: 3998
    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    3. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    4. test_keycard_send_tx_eth, id: 700767
    Device sessions

    5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
    Device sessions

    2. test_1_1_chat_message_reaction, id: 6315
    Device sessions

    3. test_1_1_chat_audio_message_with_push, id: 6316
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
    Device sessions

    5. test_1_1_chat_image_send_save_reply, id: 6305
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
    Device sessions

    7. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
    Device sessions

    8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
    Device sessions

    9. test_1_1_chat_push_emoji, id: 6283
    Device sessions

    status-im-auto avatar Oct 10 '22 13:10 status-im-auto

    Hi, @qfrank! I will move PR to the Review column as currently it is not approved and thus is not ready for testing yet. As soon as it will be approved and all review comments are resolved, please move it back to E2E column. Thank you!

    pavloburykh avatar Oct 11 '22 10:10 pavloburykh

    97% of end-end tests have passed

    Total executed tests: 87
Failed tests: 3
Passed tests: 84

    IDs of failed tests: 5756,700732,3997

    Failed tests (3)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_highligted, id: 5756

    Device 1: Double tap on: HomeButton
    Device 1: Find `HomeButton` by `xpath`: `//*[contains(@content-desc,'tab, 1 out of 5')]` 
    critical/chats/test_group_chat.py:162: in test_group_chat_highligted
    [self.homes[i].home_button.double_click() for i in range(3)]
critical/chats/test_group_chat.py:162: in <listcomp>
    [self.homes[i].home_button.double_click() for i in range(3)]
../views/base_element.py:110: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:110: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen



    Device sessions

    2. test_group_chat_add_new_member_activity_centre, id: 700732

    Device 3: Find Button by accessibility id: notifications-unread-badge
    Device 3: Tap on found: Button 
    critical/chats/test_group_chat.py:118: in test_group_chat_add_new_member_activity_centre
    self.homes[2].get_chat(self.chat_name).click()
../views/home_view.py:257: in get_chat
    chat_in_ac.wait_for_element(20)
../views/base_element.py:117: in wait_for_element
    raise TimeoutException(
 Device `3`: `ActivityCenterChatElement` by` xpath`: `//*[@content-desc='chat-name-or-sender-text'][starts-with(@text,'ggkhrzn')]/../..` is not found on the screen after wait_for_element



    Device sessions

    3. test_group_chat_leave_relogin, id: 3997

    Device 1: Double tap on: HomeButton
    Device 1: Find HomeButton by xpath: //*[contains(@content-desc,'tab, 1 out of 5')] 
    critical/chats/test_group_chat.py:178: in test_group_chat_leave_relogin
    [self.homes[i].home_button.double_click() for i in range(2)]
critical/chats/test_group_chat.py:178: in <listcomp>
    [self.homes[i].home_button.double_click() for i in range(2)]
../views/base_element.py:110: in double_click
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:110: in <listcomp>
    [self.find_element().click() for _ in range(2)]
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen



    Device sessions

    Passed tests (84)

    Click to expand

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
    Device sessions

    2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    3. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    2. test_browser_bookmarks_create_edit_remove, id: 702077
    Device sessions

    3. test_browser_blocked_url, id: 702072
    Device sessions

    4. test_browser_delete_close_tabs, id: 702076
    Device sessions

    5. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Device sessions

    6. test_browser_web3_permissions_testdapp, id: 702078
    Device sessions

    7. test_public_chat_tag_message, id: 700738
    Device sessions

    8. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    9. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Device sessions

    10. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    11. test_browser_offline, id: 702075
    Device sessions

    12. test_browser_invalid_url, id: 702074
    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    3. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    4. test_keycard_send_tx_eth, id: 700767
    Device sessions

    5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    Class TestPairingSyncMultipleDevicesMerged:

    1. test_pairing_sync_clear_history, id: 702394
    Device sessions

    2. test_pairing_sync_contacts_block_unblock, id: 702196
    Device sessions

    3. test_pairing_sync_initial_profile_picture, id: 702392
    Device sessions

    4. test_pairing_sync_initial_bookmarks, id: 702393
    Device sessions

    5. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Device sessions

    6. test_pairing_sync_1_1_chat_message, id: 702198
    Device sessions

    7. test_pairing_sync_public_chat_add_remove, id: 702199
    Device sessions

    8. test_pairing_sync_initial_public_chats, id: 702195
    Device sessions

    9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
    Device sessions

    Class TestRestoreOneDeviceMerged:

    1. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
    Device sessions

    3. test_restore_seed_phrase_field_validation, id: 700750
    Device sessions

    4. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
    Device sessions

    2. test_1_1_chat_message_reaction, id: 6315
    Device sessions

    3. test_1_1_chat_audio_message_with_push, id: 6316
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
    Device sessions

    5. test_1_1_chat_image_send_save_reply, id: 6305
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
    Device sessions

    7. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
    Device sessions

    8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
    Device sessions

    9. test_1_1_chat_push_emoji, id: 6283
    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_sticker_1_1_public_chat_mainnet, id: 702157
    Device sessions

    2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
    Device sessions

    3. test_ens_mention_push_highlighted_public_chat, id: 702156
    Device sessions

    4. test_ens_mention_nickname_1_1_chat, id: 702155
    Device sessions

    5. test_ens_purchased_in_profile, id: 702152
    Device sessions

    6. test_start_new_chat_public_key_validation, id: 702158
    Device sessions

    Class TestSendTxDeviceMerged:

    1. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    3. test_send_tx_token_8_decimals, id: 700764
    Device sessions

    4. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    3. test_group_chat_offline_pn, id: 3998
    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_contact_block_unblock_public_chat_offline, id: 702176
    Device sessions

    2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
    Device sessions

    3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
    Device sessions

    4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
    Device sessions

    5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
    Device sessions

    Class TestWalletManagementDeviceMerged:

    1. test_wallet_manage_assets, id: 700758
    Device sessions

    2. test_wallet_add_account_seed_phrase_validation, id: 700762
    Device sessions

    3. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    4. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    6. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
    Device sessions

    Class TestPublicChatMultipleDeviceMerged:

    1. test_public_chat_message_edit, id: 700734
    Device sessions

    2. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    3. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    5. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    6. test_public_chat_link_send_open, id: 700736
    Device sessions

    7. test_public_chat_mark_all_messages_as_read, id: 6270
    Device sessions

    8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    10. test_public_chat_message_delete, id: 700735
    Device sessions

    Class TestOnboardingOneDeviceMerged:

    1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    2. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    3. test_onboarding_share_contact_address, id: 700743
    Device sessions

    4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    6. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    status-im-auto avatar Oct 11 '22 12:10 status-im-auto

    100% of end-end tests have passed

    Total executed tests: 3
Failed tests: 0
Passed tests: 3

    Passed tests (3)

    Click to expand

    Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_leave_relogin, id: 3997
    Device sessions

    2. test_group_chat_add_new_member, id: 700732
    Device sessions

    3. test_group_chat_highligted, id: 5756
    Device sessions

    status-im-auto avatar Oct 12 '22 14:10 status-im-auto

    Hello @qfrank, thank you for PR!

    Tested:

    • Avalanche with https://traderjoexyz.com/home#/ dapp
    • Matic (Polygon) with https://app.gamee.com/ dapp
    • BSC Network with https://pancakeswap.finance/ dapp
    • https://app.uniswap.org/#/swap for switching back to Mainnet
    • denial of the request at each of the steps
    • on Android and iOS devices
    • regular and keycard accounts

    Looks good to me except for one thing: switching to xDai (Gnosis) network does not work correctly using this functionality.

    Steps:

    • open some Gnosis dapp in browser (i.e. https://honeyswap.1hive.eth.limo//#/swap or https://thehashavatars.com)
    • connect wallet

    Expected result: user is prompted to switch network Actual result: nothing happens

    If I switch the network to xDai manually I see my wallet connected in the DApp.

    https://user-images.githubusercontent.com/67952253/195576684-aa8690fc-3e24-4300-93b0-9f2d787d8023.MP4

    Maybe that's because the RPC URL has been updated again: https://docs.gnosischain.com/tools/wallets/metamask.

    You still can switch to this network manually from the settings despite the fact that we still have https://gnosischain-rpc.gateway.pokt.network URL while the new one is https://rpc.gnosischain.com

    Can you check please @qfrank? @flexsurfer should we also update this URL in our networks list? I got an error 'Network request failed' a couple of times when switching manually, but couldn't reproduce

    qoqobolo avatar Oct 13 '22 10:10 qoqobolo

    @flexsurfer should we also update this URL in our networks list? I got an error 'Network request failed' a couple of times when switching manually, but couldn't reproduce

    its hard to say, probably we could create an issue, so we could investigate more

    flexsurfer avatar Oct 13 '22 11:10 flexsurfer

    Hi @qoqobolo , i've checked https://honeyswap.1hive.eth.limo//#/swap and https://thehashavatars.com/ , looks like they won't call wallet_addEthereumChain/wallet_switchEthereumChain neither, so user need switch network manually, in another word, these dapps don't use EIP-3085/EIP-3326

    qfrank avatar Oct 14 '22 05:10 qfrank

    @qfrank got it, thanks for checking and for your work! PR can be merged.

    qoqobolo avatar Oct 14 '22 08:10 qoqobolo