Charlie Gunyon

Results 9 comments of Charlie Gunyon

I don't think that solves it (it also looks like documentation for C#), the issue here is that there's no factory/alternate constructor for creating a `Timestamp` from a `datetime` in...

It also seems necessary for UUID primary keys, which are pretty common these days.

Looks like singleplayer loads up fine, multiplayer still needs testing

Hiya, thanks for filing this! The MessagePack spec contains this little tidbit: > If an object can be represented in multiple possible output formats, serializers SHOULD use the format which...

Hi! I see what you're saying. If you're reading individual members (like `u8`, `s16`, etc.) those all get copied. If you have a big binary blob in your data, you...

Thinking about this some more, I think the main issue is that the code uses `cmp_read_object` for nearly everything, which reads the data using `cmp.reader` into a stack-allocated `cmp_object_t`, and...

I try to keep the C++-isms to a minimum in CMP and I'm not convinced of the benefits here. I did pull in the CI changes (thanks!), but I think...

OK I can live with that, thanks for doing it :)