Cameron Angliss
Cameron Angliss
Hi @hsahovic, sorry, I saw what you wrote but I've just not gotten around to adding the unit tests yet. If you feel like you have the time and want...
Hi @hsahovic! I'm done with my semester now so I have time to finish this PR. Open it back up and I'll get this done.
Update: I've got this branch working with updated unit tests up, so it should be good as soon as you reopen it.
Examples are no longer deprecated. @hsahovic this can be closed.
Thanks for your quick response! I agree that pulling in information from the Teambuilder would be useful as well, but I think as a first step it would be good...
@hsahovic @caymansimpson I've actually been sitting on a solution for this for a little while now, but it isn't fully generalized out to the point that it's good to merge...
@acxz all done!
@hsahovic this is ready to go whenever you're ready to take it!
Just as a note, I could be doing `reset_battles` on `self` and `opponent` in the `_battle_against` method, and that's probably the thing that makes most sense given that the function...
After using this diff myself for a little while, I decided that it would be better to just to reset_battles in the battle_against method. I just put that change in.