Noah Lev

Results 119 comments of Noah Lev

Do you mind posting a brief summary of the feature as it currently stands? It seems there was a lot of back-and-forth over things like syntax in the implementation PR.

@rfcbot concern syntax complexity This seems good overall, but a couple comments: 1. Is there any particular reason for supporting both `{class=foo}` and `{.foo}`? It seems like Pandoc only supports...

> [Pandoc supports both variants](https://pandoc.org/try/?params=%7B%22text%22%3A%22%60%60%60rust+%7Bclass%3Dfoo+.bar%7D%5Cnfn+main%28%29+%7B%7D%5Cn%60%60%60%22%2C%22to%22%3A%22html5%22%2C%22from%22%3A%22markdown%22%2C%22standalone%22%3Afalse%2C%22embed-resources%22%3Afalse%2C%22table-of-contents%22%3Afalse%2C%22number-sections%22%3Afalse%2C%22citeproc%22%3Afalse%2C%22html-math-method%22%3A%22plain%22%2C%22wrap%22%3A%22auto%22%2C%22highlight-style%22%3Anull%2C%22files%22%3A%7B%7D%2C%22template%22%3Anull%7D). Thanks, I didn't see that in the docs. 👍 > https://github.com/rust-lang/rust/issues/115938 / https://github.com/rust-lang/rust/pull/115947#issuecomment-1724361386 Hmm, I'm still unclear on how this relates to the `custom,class:language-c` example...

> It doesn't add `class:foo` as syntax that adds a class. It's just a bareword, the same as `ASN.1`. The colon isn't special syntax at all. The PR description with...

I thought this was implemented already? I know that the rustc-dev-guide uses `./foo.md`-style links.

This is a work-in-progress since the tests are still segfaulting. They segfault while gmock is printing a message to stdout; specifically while stdout is about to be flushed.

Thanks for the detailed reply! And apologies for my delayed response. I've applied the fixes you mentioned (including rebasing on master), but my tests are still failing, and indeed with...

> First, I'm running on macOS Sonoma 14.3.1 (the latest), and I've just run `brew update; brew upgrade`. Oh, I forgot to mention that I'm on Sonoma 14.1 (slightly older),...

Weirder still, if I cd into `build` and then `make`, I get a static assertion error regarding a heap-layers object (only including the last bit of output). Were you using...

I think this is a well-known borrow-checker bug — see https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/borrow.20error. @rustbot label: T-compiler