Kamil Śliwak

Results 777 comments of Kamil Śliwak

That looks nice. This is only for the latest version though, isn't it? I don't see any workarounds that would probably be required to build earlier versions. I mean, if...

Quick update: this is already mostly done in #16268, #16271 and https://github.com/argotorg/solc-bin/pull/167/. The only thing that is missing are soltest and CLI test runs using the new binaries. 0.8.31 tomorrow...

Since this issue is one of the metadata improvements [requested by Sourcify](https://github.com/ethereum/sourcify/issues/1523), I looked into it now to see what we can do about it. The description is fairly dense...

Now the question is what do we do about it. ### CID version As documented in [Encoding of the Metadata Hash in the Bytecode](https://docs.soliditylang.org/en/develop/metadata.html#encoding-of-the-metadata-hash-in-the-bytecode), the type of hash we use...

@Jorropo Oh, I see. Thanks for the extra detail. So BLAKE3 is important because it's an implicit way to chunk file content without making blocks smaller. And that's why UnixFS...

> a fixed reproducible chunker is a downside anytime reproducibility is not needed. Hmm... I thought that being able to independently serve the same content under the same link was...

Please also add the missing validation you found in https://github.com/ethereum/solidity/pull/15666#discussion_r1939497765.

@kuzdogan Does sourcify make any use of this flag? I wonder why it's even in CBOR metadata and not in the JSON metadata.

Another situation where we should be setting the flag is AST import, which is still considered experimental. Ideally we'd do that for EVM assembly import as well, but there we...

This needs a changelog entry. Also, please triage the issue before starting to work on it :)