solidity icon indicating copy to clipboard operation
solidity copied to clipboard
verified publisher icon ethereum

Refactor `compileViaYul` test setting

Open rodiazet opened this issue 11 months ago • 4 comments

This PRs refactors using of compileViaYul setting in semantic tests with using enumSetting

~Depends on: #15666~ Merged

rodiazet avatar Feb 03 '25 16:02 rodiazet

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

github-actions[bot] avatar Feb 03 '25 16:02 github-actions[bot]

Please also add the missing validation you found in https://github.com/ethereum/solidity/pull/15666#discussion_r1939497765.

cameel avatar Feb 03 '25 17:02 cameel

Please also add the missing validation you found in #15666 (comment).

Ok. Do you want me to introduce similar change in SyntaxTest?

rodiazet avatar Feb 04 '25 10:02 rodiazet

Please also add the missing validation you found in #15666 (comment).

Ok. Do you want me to introduce similar change in SyntaxTest?

Added but I think we should also use enumSetting for bytecodeFormat and add a protected member to the EVMVersionRestrictedTestCase class to avoid parsing this setting twice

rodiazet avatar Feb 04 '25 11:02 rodiazet