calvbore

Results 17 comments of calvbore

@ShravanSunder Just doing a quick skim through the hooks, haven't checked if something is implemented already or not, but maybe both the ENS hooks, and the useTokenBalance hook?

Need to make sure the voucher tracks if the clone was at the head of the auction que.

There are a good amount of overflow reverts. Do you think theses are likely to affect realistic amounts provided Ditto. And any ideas for what we could do to mitigate...

I'm wondering if we should increase the gas stipend? or if there is some way we can allow a user to increase some minimum amount.

yeah, if there's a protocol built with the token ejector and and `0` is passed as the arg then none of their business logic will be executed, so there needs...

I'm a little concerned that removing those checks will make it easier for a malicious token to attack ditto. For example, if it's an upgradeable token that functions as expected...

Are you referring to the clone or the underlying NFT?

yeah, sounds good. It is also possible for trading to happen on clones where no underlying NFT exists in the first place, as well. So we should also document that...

So a function that returns the clone's worth at the head of the queue, and the subsidy summed together?

some additional notes from our discussion. - If the clone owner reverts on the underlying NFT's transfer, the clone should be burned in all cases. Remaining questions is what to...